adds condition to check XDG_DATA_HOME to set global_dir value #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sh-rp
requested changes
Mar 5, 2025
| if not os.path.isdir(os.path.join(home, DOT_DLT)): | ||
| return os.path.join(os.environ["XDG_DATA_HOME"], "dlt") | ||
| else: | ||
| warnings.warn( |
There was a problem hiding this comment.
we use logger.warning in our codebase, maybe use that instead
There was a problem hiding this comment.
If you mean dlt.common.logger, when I import it into run_context.py the conftest fails:
ImportError while loading conftest 'tests/common/runtime/conftest.py'.
tests/common/runtime/conftest.py:1: in <module>
from tests.utils import preserve_environ
tests/utils.py:43: in <module>
ALL_DESTINATIONS = dlt.config.get("ALL_DESTINATIONS", list) or [
dlt/common/configuration/accessors.py:39: in get
value, _ = self._get_value(field, expected_type)
dlt/common/configuration/accessors.py:74: in _get_value
for provider in self.config_providers:
dlt/common/configuration/accessors.py:104: in config_providers
return [p for p in self._get_providers_from_context()]
dlt/common/configuration/accessors.py:64: in _get_providers_from_context
return Container()[PluggableRunContext].providers.providers
dlt/common/configuration/container.py:67: in __getitem__
item = spec()
dlt/common/configuration/specs/pluggable_run_context.py:90: in __init__
self._plug(run_dir=None)
dlt/common/configuration/specs/pluggable_run_context.py:161: in _plug
m = plugins.manager()
dlt/common/configuration/plugins.py:47: in manager
return Container()[PluginContext].manager
dlt/common/configuration/container.py:67: in __getitem__
item = spec()
dlt/common/configuration/plugins.py:31: in __init__
self.manager.add_hookspecs(run_context)
E AttributeError: 'function' object has no attribute 'get'
Without importing it, the tests run normally.
There was a problem hiding this comment.
OK! let's keep the warn. When creating a run_context, logger may not be yet available... Let's skip this for now
|
For the test, for now I have this test passing in def test_context_with_xdg_dir() -> None:
import tempfile
temp_data_home = os.path.join(tempfile.gettempdir(), "test")
os.environ["XDG_DATA_HOME"] = temp_data_home
ctx = PluggableRunContext()
run_context = ctx.context
assert run_context.global_dir == os.path.join(temp_data_home, "dlt")
os.environ.pop("XDG_DATA_HOME")As for the failing CI above, it seems I have to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check for XDG_DATA_HOME env var when setting the global directory for storing pipeline data.
If the variable if set but
~/.dltexists, then it is used with a warning raised to move it manually and not break backwards compatibility.Related Issues
Additional Context